Repository navigation
[NO QA] Create test to validate that copilot has access - #75802
Conversation
…raw account are the same
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
@KioCoan Kindly let me know if C+ review is required here |
|
@abdulrahuman5196 based on similar PRs, I think it's needed. |
|
sure will check on this |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
@KioCoan kindly check on the comments
| }, | ||
| ], | ||
| errors: { | ||
| depositWithdrawalAccountError: 'The deposit and withdrawal accounts are the same.', |
There was a problem hiding this comment.
the test title says returns correct reason but in the then section we are only checking if there are errors present instead of exact errors? is this expected?
There was a problem hiding this comment.
I updated the test to validate the exactly message + error existence. Nice suggestion.
Add validation for specific error message and fix TS
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppNA Android: mWeb ChromeNA iOS: HybridAppNA iOS: mWeb SafariNA MacOS: Chrome / SafariNA MacOS: DesktopNA |
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @roryabraham
🎀 👀 🎀
C+ Reviewed
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #69912 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
@roryabraham Gentle ping on this |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.72-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.2.72-2 🚀
|
Explanation of Change
This PR add a test case to validate that copilot has access to but deposit and withdraw account are the same
Fixed Issues
$ #69912
Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.